Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: ADR-0003: customization of list output #103

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

jhoward-lm
Copy link
Contributor

@jhoward-lm jhoward-lm commented Jul 11, 2024

3. List output customization

Date: 2024-07-11

Status

Accepted

Context

This is an enhancement proposal to allow users to customize the output of bomctl list that lists
SBOM Documents by specifying a search expression, filter, or template.

Decision

Update bomctl list to accept an expression to customize the output table of SBOM documents.
This would be similar in functionality to the --format option used by various docker commands.

Either the existing use of positional argument will be retained, or an additional flag (such as
--format or --query) will be added.

The supported search/filter expression syntaxes will be:

  • Common Expression Language (CEL)
  • Go templates
  • GraphQL

The expression would then be parsed to construct a SQL query or call to the ent backend to
retrieve and display the desired table(s)/column(s).

A separate bomctl query command will be used to query/filter nodes, bomctl list is reserved
for finding SBOM Documents.

@puerco recommended reading the store into CEL to simplify listing.

Consequences

This change would allow users greater control over inspecting the contents of their cached SBOMs.

@jhoward-lm jhoward-lm added the documentation Improvements or additions to documentation label Jul 11, 2024
@jhoward-lm jhoward-lm self-assigned this Jul 11, 2024
@jhoward-lm jhoward-lm requested a review from a team as a code owner July 11, 2024 18:25
@idunbarh
Copy link
Member

I don't have an opinion on this. @eddiezane and @ashearin what are your thoughts?

@idunbarh
Copy link
Member

ADR was discussed and approved during the community call on 7/29/2024. Minor updates were added to clarify a separate bomctl query command will be used to filtering nodes.

@idunbarh idunbarh merged commit 3efeeb8 into main Aug 5, 2024
8 checks passed
@idunbarh idunbarh deleted the adr/list-output-customization branch August 5, 2024 15:51
@idunbarh idunbarh added the adr Architecture Decision Records use to decide architecture or implementation details of `bomctl` label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adr Architecture Decision Records use to decide architecture or implementation details of `bomctl` documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants