Fix persisting Kraken trades in QuestDB #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Kraken ws API does not return a `trade_id`. When the Quest backend tries to insert a record with a `None` id it will just ignore that insert.
bmoscon
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue (#1038) where inserting Kraken trades into QuestDB would always fail silently.
When
TradeQuestpersists aTradeit tried to useTrade.idfor for the dbidfield. But the old Kraken websocket does not return trade id's, which meansTradeQuestattempts to insert every record with idNone. But the QuestDB server will silently ignore any record that have that has it's id set toNone.Since in quest
idis not a required field in qdb (actually not sure if this is specific to qdb, or more generally true for the InfluxDB line protocol), this pr only adds theidpeoperty to the request if it's notNone.Description of code - what bug does this fix / what feature does this add?