This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
Generate swagger from a package and update swagger for delete-environ… #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjbuys
approved these changes
Jan 25, 2018
| .filterInputsBy(new FilterBuilder().includePackage(pkg))); | ||
| Set<Class<?>> springMVCClasses = | ||
| reflections.getTypesAnnotatedWith( | ||
| org.springframework.web.bind.annotation.RestController.class); |
There was a problem hiding this comment.
Hm, we don't have a direct dependency on this in the build.gradle, is it coming in as a transitive dependency? Might be worth adding an explicit dependency in that case.
There was a problem hiding this comment.
Yes, it comes from the "swagger-maven-plugin", which we use to generate swagger from Spring mvc.
Not sure what's the value we add for explicit dependency for spring-web. I would see it's better to use the transitive dependency from swagger to avoid potential problem to maintain the same spring version within swagger or different spring versions.
frontend-service/build.gradle
Outdated
| @@ -60,15 60,8 @@ task swagger(type: GenerateSwaggerModel, dependsOn: classes) { | |||
| scanClasspath = project.sourceSets.main.runtimeClasspath | |||
|
|
|||
| // TODO: Specify API classes by package rather than name | |||
There was a problem hiding this comment.
You can probably remove this TODO now ;)
| /** A list of class names to scan for Swagger annotations */ | ||
| @Input private List<String> apiClasses = new ArrayList<>(); | ||
| /** A list of package names to scan for swagger annotations */ | ||
| @Input private List<String> apiPackages = new ArrayList<>(); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the swagger file for delete-environment API.
Testing
gradle buildLicensing
This contribution is under the terms of the Apache 2.0 License: Yes