-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
D3D12: Unhandled exception when creating more than 64 samplers #3093
Comments
Did you test it in debug build? |
Release and debug, both crash |
I've had time to look a bit through the code and I suspect the problem comes from the fact that |
@falia18 this is partial fix... I'm still working on proper fix. |
Describe the bug
On D3D12, creating more than 64 samplers will throw an exception in
DescriptorAllocatorD3D12::alloc()
on linedevice->CreateSampler(&sd, cpuHandle);
To Reproduce
Steps to reproduce the behavior:
I've forked and edited example 6-bump to reproduce the issue (https://github.com/falia18/bgfx/tree/d3d12-sampler-crash-example)
Clone the project and switch to branch d3d12-sampler-crash-example
Launch example 6-bump with --d3d12 and crash will occur after ~20 frames.
Expected behavior
Sampler creation proceeds without exception.
Additional context
Tested on Windows 10 with both NVIDIA and AMD GPU
The text was updated successfully, but these errors were encountered: