Refactor MainService to prevent unnecessary activity starts #243
107
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bk138
requested changes
Oct 18, 2024
app/src/main/java/net/christianbeier/droidvnc_ng/MainService.java
Outdated
Show resolved
Hide resolved
app/src/main/java/net/christianbeier/droidvnc_ng/MainService.java
Outdated
Show resolved
Hide resolved
added 2 commits
October 18, 2024 18:15
There should be no logic change. Just moving the code in separate methods and directly check the condition instead of checking in the activity. Most of the time this will safe jumping between activities and service as permissions are only requested the first time. This helps when automating the start process of a session.
Niels-Be
force-pushed
the
service-cleanup
branch
from
12ecada
to
17bf05c
Compare
|
@bk138 sorry about that. There is an option to hide those in the UI but I pushed again without whitespace changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was about to automate the session startup with my DPC application.
My device is in Lock Task Mode, so starting activities is prohibited.
This cleans up the startup process so that in case all permissions are granted no activities have to be launched.
There should be no logic change. Just moving the code in separate methods
and directly check the permission condition in the service before starting the activity to request it.
Most of the time this will save the overhead of jumping between activities and service
as permissions are only requested the first time.
This helps when automating the start process of a session.
Also send a response to the caller in some failure cases.