Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 3.5.0, ServiceAccount reverts back to default #359

Closed
dmfrey opened this issue Oct 6, 2024 · 1 comment · Fixed by #360
Closed

Upgrade to 3.5.0, ServiceAccount reverts back to default #359

dmfrey opened this issue Oct 6, 2024 · 1 comment · Fixed by #360
Assignees
Labels
bug Something isn't working

Comments

@dmfrey
Copy link

dmfrey commented Oct 6, 2024

Details

What steps did you take and what happened:
After upgrading HelmRelease to 3.5.0 for amd-gpu-node-labeler with a pre-defined RBAC configuration (ClusterRole, ClusterRoleBinding, and ServiceAccount), the serviceAccount configuration did not seem to be honored which caused the pods in the Daemonset to use the Default ServiceAccount instead of the custom defined one which has the correct permissions to read the node.

    serviceAccount:
      create: false
      name: amd-gpu-node-labeller

What did you expect to happen:

The Pods should use the defined service account

Anything else you would like to add:

Reverting the app-template to 3.4.0 fixes the issue.

Additional Information:

@dmfrey dmfrey added the bug Something isn't working label Oct 6, 2024
@bjw-s
Copy link
Owner

bjw-s commented Oct 6, 2024

We've happened to identify this issue earlier today on Discord. @LarryGF has taken it upon himself to push a fix PR ❤️ 3.5.1 should be rolling out soon afterwards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants