Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/kafka] Flexible tls config for metrics exporter #5520

Merged
merged 1 commit into from
Feb 17, 2021
Merged

[bitnami/kafka] Flexible tls config for metrics exporter #5520

merged 1 commit into from
Feb 17, 2021

Conversation

sveba
Copy link
Contributor

@sveba sveba commented Feb 17, 2021

Description of the change

Flexible JKS configuration for the metrics-exporter.
In my company we are using cert-manager to automate certificate management. The cert-manager creates a secret, which is completely different, than the one forced by the kafka-helm-chart.

We need to be able to change the default JKS secret and key mappings.

Benefits

This is helpful for anyone who is using already some kind of cert-management or even using a different scheme for creating the certs.

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [bitnami/chart])

@sveba sveba force-pushed the feature/metrics_exporter_tls branch from 792647e to 8ba26a7 Compare February 17, 2021 08:24
rafariossaa
rafariossaa suggested changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@rafariossaa rafariossaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you very much for adding this feature.
It looks good to me, but could you take care of the linter error ?

@sveba
Copy link
Contributor Author

sveba commented Feb 17, 2021

Thanks you very much for adding this feature.
It looks good to me, but could you take care of the linter error ?

done

@sveba sveba requested a review from rafariossaa February 17, 2021 08:33
@rafariossaa rafariossaa merged commit ec76369 into bitnami:master Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafariossaa rafariossaa rafariossaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sveba @rafariossaa