[bitnami/odoo] Odoo major #4071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 20, 2020 16:15
Signed-off-by: joancafom <[email protected]>
Improve README structure Bump PostgreSQL version Signed-off-by: joancafom <[email protected]>
Signed-off-by: joancafom <[email protected]>
dani8art
approved these changes
Oct 22, 2020
| * Now the upgrade works | ||
|
|
||
| ```console | ||
| $ helm upgrade odoo bitnami/odoo --set odooPassword=$ODOO_PASSWORD --set postgresql.postgresqlPassword=$POSTGRESQL_PASSWORD |
There was a problem hiding this comment.
Didn"t you need the existing PVC to upgrade postgres?
There was a problem hiding this comment.
Yes, but there is no need to specify it as in the previous step we have used --cascade=false with PostgreSQL. This way, the old pod (and the PVC) is preserved. Then, when the pod is deleted, a new one with the correct labels comes up and automatically re-uses the same PVC. Think of it as a failing pod that is re-scheduled by K8s, it will reuse the PVC 😄
This was derived from the upgrading instructions in PostgreSQL Chart itself.
garettmd
pushed a commit
to garettmd/odoo
that referenced
this pull request
Jan 31, 2024
…ami#4071) * Update PostgreSQL Req file Signed-off-by: joancafom <[email protected]> * Change labels and annotations Improve README structure Bump PostgreSQL version Signed-off-by: joancafom <[email protected]> * Add standardizations Signed-off-by: joancafom <[email protected]> * Add externalSecret support * Add commonAnnotations to ingress * Improve NOTES * Bump Chart and README upgrade details * Fix indentation issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR updates PostgreSQL subchart to the new major version, which includes breaking changes. More info at #3021
As this requires a major bump in this chart, it has been adapted to follow some standardizations found in other Bitnami Charts. Please check additional information or README for a detailed list of new standard features.
The most important change is in the labels, that are adapted to follow the Helm charts standard labels.
Benefits
Standardization, up-to-date subcomponents,
Possible drawbacks
Breaks backwards compatibility
Applicable issues
NA
Additional information
Checklist
Chart.yamlaccording to semver.[bitnami/chart])values-production.yamlapart fromvalues.yaml, ensure that you implement the changes in both files