Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/several] Adapt Chart.yaml to set desired OCI annotations #16546

Merged
merged 4 commits into from
May 9, 2023
Merged

[bitnami/several] Adapt Chart.yaml to set desired OCI annotations #16546

merged 4 commits into from
May 9, 2023

Conversation

carrodher
Copy link
Member

@carrodher carrodher commented May 9, 2023 •
edited
Loading

With changes announced at helm/helm#11204, it will be possible to match fields in the Chart.yaml files with OCI annotations.

As internally agreed, this PR modifies the different fields present in the different Chart.yaml files to unify them and make them match the OCI annotations in the desired way.

From Open Containers annotation:

org.opencontainers.image.authors contact details of the people or organization responsible for the image (freeform string)
org.opencontainers.image.url URL to find more information on the image (string)
org.opencontainers.image.source URL to get source code for building the image (string)

Chart.yaml fields were modified/unified to obtain the following annotations

"org.opencontainers.image.authors": "VMware, Inc."
"org.opencontainers.image.url": https://bitnami.com
"org.opencontainers.image.source": https://github.com/bitnami/charts/tree/main/bitnami/wildfly

Merge branch "main" into ociannotations
b1a5090 
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label May 9, 2023
@bitnami-bot bitnami-bot requested a review from corico44 May 9, 2023 16:34
Bump chart version
8b1910f 
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
@carrodher carrodher assigned carrodher and unassigned corico44 May 9, 2023
@carrodher carrodher removed the request for review from corico44 May 9, 2023 16:39
Merge branch "main" into ociannotations
0f040b6 
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
@carrodher carrodher merged commit fc9b18f into main May 9, 2023
@carrodher carrodher deleted the ociannotations branch May 9, 2023 19:05
@github-actions github-actions bot added the solved label May 9, 2023
@absoludity absoludity mentioned this pull request May 10, 2023
Merged
3 tasks
garettmd pushed a commit to garettmd/odoo that referenced this pull request Jan 31, 2024
[bitnami/several] Adapt Chart.yaml to set desired OCI annotations (bi…
d5a849e 
…tnami#16546)

* [bitnami/several] Adapt Chart.yaml to set desired OCI annotations

Signed-off-by: Carlos Rodríguez Hernández <[email protected]>

* Bump chart version

Signed-off-by: Carlos Rodríguez Hernández <[email protected]>

---------

Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmulero fmulero fmulero approved these changes

@javsalgar javsalgar Awaiting requested review from javsalgar

@beltran-rubo beltran-rubo Awaiting requested review from beltran-rubo

@aoterolorenzo aoterolorenzo Awaiting requested review from aoterolorenzo

Assignees

@carrodher carrodher

Labels
bitnami solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carrodher @fmulero @bitnami-bot @corico44