Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/metallb] add option to skip CRD install #15939

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

MaxRink
Copy link
Contributor

@MaxRink MaxRink commented Apr 3, 2023

Description of the change

Add a flag to skip CRD install in te metallb chart, for example if CRDs are managed externally.

Benefits

Allows management of CRDs by other resources than helm or before this chart gets applied.

Possible drawbacks

none

Applicable issues

none

Additional information

none

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: Maximilian Rink <[email protected]>
@github-actions github-actions bot added the triage Triage is needed label Apr 3, 2023
@bitnami-bot bitnami-bot requested a review from javsalgar April 3, 2023 14:41
@MaxRink MaxRink changed the title bitnami/metallb add option to skip CRD install [bitnami/metallb] add option to skip CRD install Apr 3, 2023
@javsalgar javsalgar added the verify Execute verification workflow for these changes label Apr 4, 2023
@github-actions github-actions bot added in-progress and removed triage Triage is needed labels Apr 4, 2023
@bitnami-bot bitnami-bot removed the request for review from javsalgar April 4, 2023 08:13
@bitnami-bot bitnami-bot requested a review from marcosbc April 4, 2023 08:13
Copy link
Contributor

@marcosbc marcosbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

@marcosbc marcosbc merged commit ea3a30d into bitnami:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metallb solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants