[bitnami/metallb] crds.yaml update to 0.13.9 (#15745 fix) #15781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added "interfaces" spec parameter for L2Advertisement (bitnami#15745) Signed-off-by: Willem Bermon <[email protected]>
Added vrf, serviceAllocation and serviceSelectors parameters/properties. Now up to date with helm chart based on 0.13.9. (bitnami#15745) Signed-off-by: Willem Bermon <[email protected]>
Signed-off-by: Willem Bermon <[email protected]>
likeMyCoffee
force-pushed
the
crds-update
branch
from
42683c1 to
b7ca7a2
Compare
fmulero
added
verify
jotamartos
approved these changes
Mar 30, 2023
mr-onion-2
pushed a commit
to mr-onion-2/bitnami-charts
that referenced
this pull request
Apr 3, 2023
…nami#15781) * Update crds 0.13.4 to 0.13.7 Added "interfaces" spec parameter for L2Advertisement (bitnami#15745) Signed-off-by: Willem Bermon <[email protected]> * Update crds 0.13.7 to 0.13.9 (current) Added vrf, serviceAllocation and serviceSelectors parameters/properties. Now up to date with helm chart based on 0.13.9. (bitnami#15745) Signed-off-by: Willem Bermon <[email protected]> * Charts.yaml version bump Signed-off-by: Willem Bermon <[email protected]> --------- Signed-off-by: Willem Bermon <[email protected]> Signed-off-by: Montgomery Orange <[email protected]>
mr-onion-2
pushed a commit
to mr-onion-2/bitnami-charts
that referenced
this pull request
Apr 3, 2023
…nami#15781) * Update crds 0.13.4 to 0.13.7 Added "interfaces" spec parameter for L2Advertisement (bitnami#15745) Signed-off-by: Willem Bermon <[email protected]> * Update crds 0.13.7 to 0.13.9 (current) Added vrf, serviceAllocation and serviceSelectors parameters/properties. Now up to date with helm chart based on 0.13.9. (bitnami#15745) Signed-off-by: Willem Bermon <[email protected]> * Charts.yaml version bump Signed-off-by: Willem Bermon <[email protected]> --------- Signed-off-by: Willem Bermon <[email protected]> Signed-off-by: Montgomery Orange <[email protected]>
mr-onion-2
pushed a commit
to mr-onion-2/bitnami-charts
that referenced
this pull request
Apr 3, 2023
…nami#15781) * Update crds 0.13.4 to 0.13.7 Added "interfaces" spec parameter for L2Advertisement (bitnami#15745) Signed-off-by: Willem Bermon <[email protected]> * Update crds 0.13.7 to 0.13.9 (current) Added vrf, serviceAllocation and serviceSelectors parameters/properties. Now up to date with helm chart based on 0.13.9. (bitnami#15745) Signed-off-by: Willem Bermon <[email protected]> * Charts.yaml version bump Signed-off-by: Willem Bermon <[email protected]> --------- Signed-off-by: Willem Bermon <[email protected]>
mr-onion-2
pushed a commit
to mr-onion-2/bitnami-charts
that referenced
this pull request
Apr 3, 2023
…nami#15781) * Update crds 0.13.4 to 0.13.7 Added "interfaces" spec parameter for L2Advertisement (bitnami#15745) Signed-off-by: Willem Bermon <[email protected]> * Update crds 0.13.7 to 0.13.9 (current) Added vrf, serviceAllocation and serviceSelectors parameters/properties. Now up to date with helm chart based on 0.13.9. (bitnami#15745) Signed-off-by: Willem Bermon <[email protected]> * Charts.yaml version bump Signed-off-by: Willem Bermon <[email protected]> --------- Signed-off-by: Willem Bermon <[email protected]> Signed-off-by: Montgomery Orange <[email protected]>
mr-onion-2
pushed a commit
to mr-onion-2/bitnami-charts
that referenced
this pull request
Apr 3, 2023
…nami#15781) * Update crds 0.13.4 to 0.13.7 Added "interfaces" spec parameter for L2Advertisement (bitnami#15745) Signed-off-by: Willem Bermon <[email protected]> * Update crds 0.13.7 to 0.13.9 (current) Added vrf, serviceAllocation and serviceSelectors parameters/properties. Now up to date with helm chart based on 0.13.9. (bitnami#15745) Signed-off-by: Willem Bermon <[email protected]> * Charts.yaml version bump Signed-off-by: Willem Bermon <[email protected]> --------- Signed-off-by: Willem Bermon <[email protected]> Signed-off-by: Montgomery Orange <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #15745 and extends to fix to version 0.13.9
Description of the change
L2Advertisements were missing "interfaces" parameters. This finding lead me to believe that the crds.yaml was not updated.
The comment shows 0.13.4 whereas the chart references 0.13.9 images.
Not only does this fix the L2Advertisement issue but it adds all crds features left out between 0.13.4 (current crds.yaml in chart) and the 0.13.9 version, which this chart claims to be.
Benefits
The benefit of having a metallb version with all intended features, instead of the newest chart with inaccessible settings/features.
Possible drawbacks
None that come to mind
Applicable issues
Additional information
PLEASE UPDATE THE CRDS.YAML ON EACH VERSION UPDATE!!!
Copied crds.yaml from metallb into this project keeping bitnami specific modifications.
Diffs between 0.13.4 bitnami and 0.13.4 metallb found that keep release parameters correct in this chart. These bitnami modifications were left intact for the commits made by me.
Tests
The addition of the interfaces block (commit 0.13.4 to 0.13.7) is being used by me in a project.
The 0.13.7 to 0.13.9 commit has not yet been tested.
The added yaml is directly from metallb and as intended by the metallb team.