[bitnami/grafana-loki] Add overrideConfiguration to override templated loki configuration #12417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Introduces
.loki.overrideConfiguration
which allows users to specify specific configuration overrides via yaml. This augments the sane defaults provided inloki.configuration
of the currentvalues.yaml
E.g.
will yield the following in
grafana-loki/templates/loki-configmap.yaml
Benefits
This allows better customization of Loki"s configuration while making use of the sane defaults provided.
Possible drawbacks
Long and complex Helm templating.
{{- mergeOverwrite (include "common.tplvalues.render" (dict "value" .Values.loki.configuration "context" $) | fromYaml) .Values.loki.overrideConfiguration | toYaml | nindent 4 }}
Any better ideas?
Applicable issues
Resolves #12400
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm