Skip to content

Commit

Permalink
Removed env
Browse files Browse the repository at this point in the history 
Release was still failing because `python manage.py migrate` came before gunicorn in the procfile and manage.py was using local settings
  • Loading branch information
@deven96
deven96 committed Feb 1, 2019
1 parent 056021c commit d5be245
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Procfile
View file
Original file line number Diff line number Diff line change
@@ -1,2 1,2 @@
release: python manage.py migrate
web: gunicorn --env DJANGO_SETTINGS_MODULE=ImageQ.settings.production ImageQ.wsgi --log-file - --log-level debug

This comment has been minimized.

Sign in to view

Copy link
@MeNsaaH

MeNsaaH Feb 1, 2019

Member

@deven96 why was the --env variable unset?.
Setting this args ensures that regardless of the settings used in manage.py the gunicorn runs with the settings above

This comment has been minimized.

Sign in to view

Copy link
@deven96

deven96 via email Feb 1, 2019

Author Member

This comment has been minimized.

Sign in to view

Copy link
@MeNsaaH

MeNsaaH Feb 1, 2019

Member

We might leave it for anybody trying to set it. I added it to heroku, then on second thought decided to add it as a param. The allows for smooth deployment when a new heroku instance is created

This comment has been minimized.

Sign in to view

Copy link
@deven96

deven96 via email Feb 1, 2019

Author Member

This comment has been minimized.

Sign in to view

Copy link
@MeNsaaH

MeNsaaH Feb 1, 2019

Member

Okay. It makes sense now
web: gunicorn ImageQ.wsgi --log-file - --log-level debug

0 comments on commit d5be245

Please sign in to comment.