Implement new polling popup #5340
Conversation
| color : PropertyReference("bbbBlack"); | ||
| modalTransparencyBlur : 0; | ||
| modalTransparency : 0.5; | ||
| modalTransparencyColor : black; |
There was a problem hiding this comment.
Do these modalTransparency properties need to be global? Do they actually affect different classes or only one class?
There was a problem hiding this comment.
modalTransparency is going to be used by the PopUpManager, for that reason it goes global.
| fontSize : 22; | ||
| } | ||
|
|
||
| main|MobilePopUp { |
There was a problem hiding this comment.
These two "main|MobilePopUp" definitions should be merged together. Change needs to be applied to all the other profiles also.
| } | ||
|
|
||
| /** | ||
| * Override this method in subclasses to be notified of rotation changes | ||
| */ | ||
| public function rotationHandler(rotation:String):void { | ||
| protected function onOrientationChange(event:Event):void { | ||
| invalidateDisplayList(); |
There was a problem hiding this comment.
Why do you invalidate the display list on rotation? The updateDisplayList() function should already be getting called because the View size changes when the stage size changes.
| } | ||
|
|
||
| protected function onAddedToStage(event:Event):void { | ||
| stage.addEventListener(StageOrientationEvent.ORIENTATION_CHANGE, onOrientationChange, false, 0, true); |
There was a problem hiding this comment.
I'm not a fan of adding these temporary listeners in every View. Is there an advantage to doing in this way instead of having the listener added at the Application level and having it exist for the life of the application?
| _pollButton.visible = false; | ||
| _pollButton.percentWidth = 100; | ||
| _pollButton = new Button(); | ||
| _pollButton.visible = _pollButton.includeInLayout = false; |
There was a problem hiding this comment.
MainView uses BasicLayout and I don't think setting includeInLayout applies with that layout.
There was a problem hiding this comment.
If includeInLayout is set to false, parent component will not include this child size to determine its own size. Here a BasicLayout works like a canvas.
| } | ||
|
|
||
| public function showPollingButton(visible:Boolean):void { | ||
| _pollButton.visible = _pollButton.includeInLayout = visible; |
There was a problem hiding this comment.
MainView uses BasicLayout and I don't think setting includeInLayout applies with that layout.
There was a problem hiding this comment.
Same as previous remark.
| public class UserInactivityView extends NoTabView | ||
| { | ||
| public var okButton:Button; | ||
| public class UserInactivityView extends MobilePopUp { |
There was a problem hiding this comment.
I think this class should be renamed to UserInactivityPopUp as its base class is no longer a View.
| } | ||
| } | ||
|
|
||
| private function onStageOrientation(event:StageOrientationEvent):void { | ||
| view.addButtons(meetingData.polls.getCurrentPoll()); |
There was a problem hiding this comment.
Why do you re-add the poll options on orientation change?
There was a problem hiding this comment.
The window size changes depending on the orientation, we need to add buttons back if the popup goes larger. The addButtons removes buttons then add them back.
|
|
||
| view.removeAllElements(); | ||
| view.addButtons(meetingData.polls.getCurrentPoll()); | ||
| view.stage.addEventListener(StageOrientationEvent.ORIENTATION_CHANGE, onStageOrientation); |
There was a problem hiding this comment.
Need to remove this listener in the destroy()
There was a problem hiding this comment.
…dates # Conflicts: # clients/flash/air-client/src/org/bigbluebutton/air/main/views/MenuButtons.as
No description provided.