Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expound cannot handle js/NaN #48

Closed
vemv opened this issue Nov 13, 2017 · 4 comments
Closed

Expound cannot handle js/NaN #48

vemv opened this issue Nov 13, 2017 · 4 comments
Labels
bug

Comments

@vemv
Copy link
Contributor

vemv commented Nov 13, 2017

Hi!

I found the following issue, where spec can handle NaN but Expound not:

(spec/conform (constantly false) js/NaN) -> :cljs.spec.alpha/invalid

(expound/expound (constantly false) js/NaN):

{:message "Cannot convert path. This can be caused by using conformers to transform values, which is not supported in Expound", :data {:form NaN, :val NaN, :in [], :in' []}}

Thanks for this library, we've been enjoying it at work for quite a few months now!

Cheers - Victor
@bhb
Copy link
Owner

bhb commented Nov 14, 2017

@vemv Thanks very much for reporting this issue! I'll take a look soon.

@bhb bhb added the bug label Nov 14, 2017
@bhb bhb mentioned this issue Nov 14, 2017
Merged
@bhb bhb closed this as completed in #49 Nov 14, 2017
@bhb
Copy link
Owner

bhb commented Nov 14, 2017

@vemv Thanks again for reporting this bug. I've put a fix in master and pushed 0.3.4-SNAPSHOT to clojars if you want to try it. I should be putting out a bug fix release with this and a few other bug fixes sometime in the next week.

@vemv
Copy link
Contributor Author

vemv commented Nov 14, 2017

Confirming it works! Thank you! 🍻

@bhb
Copy link
Owner

bhb commented Nov 20, 2017

I've just released 0.3.4, which includes this bug fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bhb @vemv