-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Cannot convert path" on instrumentation failures in the wild #194
Comments
@jeaye Thanks for reporting this! 😄 I could be mistaken, but that error message looks to be from an older version of Expound. Is it possible that the case in the wild is using a version prior to The reason I ask is that this sounds like it might be an instance of this bug. |
Nooooooo. I think you're right. I'll check in a couple of hours and get back to you. 🤦 |
Yeah, that is the case. That project was using |
No worries, glad that fixed it! |
Hey Ben!
I've been looking into an issue I've seen with the Expound Orchestra marriage in the wild. The reproduction case is very simple, but I haven't been able to reproduce it in Orchestra's tests (in fact, I have an Expound test case and it works swimmingly).
So, the code is actually taken from my Expound test case (linked above), but run within the environment of a larger production system. Basically, it boils down to this:
Of course, Orchestra throws an exception with the explain data. Here's what it looks like:
However, if I take that exception and do a little something like this:
Then Expound gets upset and says this:
I'm not sure yet if this is an issue with Expound or if Orchestra should be changed to give it different data. I also don't know why it's not happening in my test case, but it's happening in the wild. I'm hoping you have some info on this and I'd be happy to make any necessary changes to Orchestra to make sure it can work well with Expound. Just let me know what you need!
Thank you, sir.
P.S. The best Orchestra version to use right now is
development-SNAPSHOT
, which has been completely rewritten to be much simpler. Rather than entirely forking spec, it just patches a single function to instrument everything.The text was updated successfully, but these errors were encountered: