Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bflad/tfproviderlint
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.21.0
Choose a base ref
...
head repository: bflad/tfproviderlint
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.22.0
Choose a head ref
  • 9 commits
  • 30 files changed
  • 3 contributors

Commits on Jan 27, 2021

  1. Update R014 to work with context CRUD functions

    @armsnyder
    armsnyder committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    a856b90 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2021

  1. New Extra Checkout XR006: check for Resource that implements redundan… 

    …t Timeouts
    @magodo
    magodo committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    c94c6d5 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2021

  1. passes/R014: Call out both CRUDFunc and CRUDContextFunc in documentat… 

    …ion and reports, add parameters and results length checks
    @bflad
    bflad committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    6ce5c82 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG for #221

    @bflad
    bflad committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    33c61de View commit details
    Browse the repository at this point in the history

  3. Merge branch 'armsnyder-220-crud'

    @bflad
    bflad committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    995e1a9 View commit details
    Browse the repository at this point in the history

  4. helper/terraformtype/helper/schema: Prevent panics with function or v… 

    …ariable `Elem` field values (#224)

Reference: #223

Previously with CloudFlare provider:

```
$  tfproviderlint ./cloudflare
panic: interface conversion: ast.Expr is *ast.Ident, not *ast.CompositeLit

goroutine 5153 [running]:
github.com/bflad/tfproviderlint/helper/terraformtype/helper/schema.NewSchemaInfo(0xc000a14680, 0xc001fecfa0, 0xc00208ecd0)
	/Users/bflad/src/github.com/bflad/tfproviderlint/helper/terraformtype/helper/schema/type_schema.go:211  0x1271
github.com/bflad/tfproviderlint/helper/terraformtype/helper/schema.NewResourceInfo(0xc000a14c80, 0xc001fecfa0, 0xc002d28e01)
	/Users/bflad/src/github.com/bflad/tfproviderlint/helper/terraformtype/helper/schema/type_resource.go:90  0x33e
github.com/bflad/tfproviderlint/passes/helper/schema/resourceinfo.run.func1(0x13c06a0, 0xc000a14c80)
	/Users/bflad/src/github.com/bflad/tfproviderlint/passes/helper/schema/resourceinfo/resourceinfo.go:37  0x85
golang.org/x/tools/go/ast/inspector.(*Inspector).Preorder(0xc003c2e340, 0xc000f66b00, 0x1, 0x1, 0xc000aadb28)
	/Users/bflad/go/pkg/mod/golang.org/x/[email protected]/go/ast/inspector/inspector.go:77  0xa2
github.com/bflad/tfproviderlint/passes/helper/schema/resourceinfo.run(0xc003fc2780, 0xc003fc2780, 0x0, 0x0, 0x0)
	/Users/bflad/src/github.com/bflad/tfproviderlint/passes/helper/schema/resourceinfo/resourceinfo.go:30  0xf1
golang.org/x/tools/go/analysis/internal/checker.(*action).execOnce(0xc0036d1040)
	/Users/bflad/go/pkg/mod/golang.org/x/[email protected]/go/analysis/internal/checker/checker.go:690  0x87e
sync.(*Once).doSlow(0xc0036d1040, 0xc000961f90)
	/usr/local/Cellar/go/1.15.8/libexec/src/sync/once.go:66  0xec
sync.(*Once).Do(...)
	/usr/local/Cellar/go/1.15.8/libexec/src/sync/once.go:57
golang.org/x/tools/go/analysis/internal/checker.(*action).exec(0xc0036d1040)
	/Users/bflad/go/pkg/mod/golang.org/x/[email protected]/go/analysis/internal/checker/checker.go:579  0x65
golang.org/x/tools/go/analysis/internal/checker.execAll.func1(0xc0036d1040)
	/Users/bflad/go/pkg/mod/golang.org/x/[email protected]/go/analysis/internal/checker/checker.go:567  0x34
created by golang.org/x/tools/go/analysis/internal/checker.execAll
	/Users/bflad/go/pkg/mod/golang.org/x/[email protected]/go/analysis/internal/checker/checker.go:573  0x125
```

Now:

```
$ tfproviderlint ./cloudflare
/Users/bflad/src/github.com/cloudflare/terraform-provider-cloudflare/cloudflare/import_cloudflare_load_balancer_monitor_test.go:13:28: AT001: missing CheckDestroy
...
```
    @bflad
    bflad authored Feb 15, 2021
    Configuration menu
    Copy the full SHA
    fd0bd45 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'unsed_timeout' of ssh://github.com/magodo/tfproviderlin… 

    …t into magodo-unsed_timeout
    @bflad
    bflad committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    37f8ec3 View commit details
    Browse the repository at this point in the history

  6. xpasses/XR006: Support Context functions and clarify report wording

    @bflad
    bflad committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    b09de3f View commit details
    Browse the repository at this point in the history

  7. Merge branch 'magodo-unsed_timeout'

    @bflad
    bflad committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    3ab8870 View commit details
    Browse the repository at this point in the history
Loading