Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bflad/tfproviderlint
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.19.0
Choose a base ref
...
head repository: bflad/tfproviderlint
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.20.0
Choose a head ref
  • 3 commits
  • 112 files changed
  • 2 contributors

Commits on Oct 29, 2020

  1. checks/АТ001: Add optional -ignored-filename-suffixes and -ignored-fi… 

    …lename-prefixes parameters (#210)

Verified on AzureRM:

```console
$ tfproviderlint -help
Usage of tfproviderlint:
  -AT001
    	enable AT001 analysis
  -AT001.ignored-filename-prefixes string
    	Comma-separated list of file name prefixes to ignore (default "data_source_")
  -AT001.ignored-filename-suffixes string
    	Comma-separated list of file name suffixes to ignore
...

$ tfproviderlint -AT001 ./...
/Users/bflad/src/github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/apimanagement/tests/api_management_api_data_source_test.go:14:28: AT001: missing CheckDestroy
/Users/bflad/src/github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/apimanagement/tests/api_management_api_data_source_test.go:38:28: AT001: missing CheckDestroy
/Users/bflad/src/github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/apimanagement/tests/api_management_api_version_set_data_source_test.go:14:36: AT001: missing CheckDestroy
/Users/bflad/src/github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/apimanagement/tests/api_management_data_source_test.go:14:36: AT001: missing CheckDestroy
/Users/bflad/src/github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/apimanagement/tests/api_management_data_source_test.go:35:36: AT001: missing CheckDestroy
/Users/bflad/src/github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/apimanagement/tests/api_management_group_data_source_test.go:14:36: AT001: missing CheckDestroy
...

$ tfproviderlint -AT001 -AT001.ignored-filename-suffixes=data_source_test.go ./...
$
```

And AWS:

```console
$ tfproviderlint -AT001 ./aws
$ 
```
    @favoretti
    favoretti authored Oct 29, 2020
    Configuration menu
    Copy the full SHA
    da747f3 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG for #210

    @bflad
    bflad authored Oct 29, 2020
    Configuration menu
    Copy the full SHA
    062a421 View commit details
    Browse the repository at this point in the history

  3. New Check: AT009: Check for acctest.RandStringFromCharSet that can be… 

    … acctest.RandString (#211)

Reference: #175

Includes new helper/terraformtype/helper/acctest package and passes/helper/acctest/randstringfromcharsetcallexpr.
    @bflad
    bflad authored Oct 29, 2020
    Configuration menu
    Copy the full SHA
    36f478c View commit details
    Browse the repository at this point in the history
Loading