Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed firefox support, added popup menu #103

Merged
merged 4 commits into from
Apr 10, 2020

Conversation

adambriny
Copy link
Contributor

In this PR

Screenshots

Firefox left-click popup

firefox_popup

Firefox right-click menu

firefox_rightclick

Firefox extension settings

firefox_options

Firefox options from PR tree

firefox-options-from-page

Chrome left-click popup

chrome_popup

@berzniz
Copy link
Owner

berzniz commented Apr 3, 2020

Hi Adam,

Thanks for submitting this PR! This looks great.

I’ll have to test and merge it, and I’ll hopefully do it soon. Times are a bit crazy right now, so my availability is not as usual. I do hope to have time to test and merge it next week.

From the top of my head, I remember placing the options in a pop up caused the extension storage not to work. I’ll have to review again.

@adambriny
Copy link
Contributor Author

Thanks you! 😊 Sure, I think the couple weeks were a bit crazy for many of us.
Regarding the pop up, I didn't experienced any issue with it, but mostly I checked it on Firefox.
I can't wait to see it released.

@berzniz
Copy link
Owner

berzniz commented Apr 6, 2020

Code looks good, well done 👏

Going through some testing now to make sure everything works on both browsers.

@berzniz
Copy link
Owner

berzniz commented Apr 10, 2020

Great. I tested and the new functionality works on Firefox and there are no regressions. The Chrome options popup doesn't work, but this can be handled in a different PR in the future.

@berzniz berzniz merged commit 101b09f into berzniz:master Apr 10, 2020
@berzniz
Copy link
Owner

berzniz commented Apr 10, 2020

This will be included in version 1.0.128, submitted today to Mozilla

@adambriny adambriny deleted the bugfix/firefox branch April 10, 2020 17:55
@adambriny
Copy link
Contributor Author

Cool, already got the update. 👍 I'll check the options popup issue in Chrome next week.

@adambriny
Copy link
Contributor Author

adambriny commented Apr 13, 2020

@berzniz I took a look on the options popup on Chrome, and it worked like charm to me. I could modify the settings and the were applied after a tab refresh. The chrome version was 81.0.4044.92 (64 bit) and I built and loaded the extension in dev mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension not working for Github enterprise in Firefox
2 participants