-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed firefox support, added popup menu #103
Conversation
Hi Adam, Thanks for submitting this PR! This looks great. I’ll have to test and merge it, and I’ll hopefully do it soon. Times are a bit crazy right now, so my availability is not as usual. I do hope to have time to test and merge it next week. From the top of my head, I remember placing the options in a pop up caused the extension storage not to work. I’ll have to review again. |
Thanks you! 😊 Sure, I think the couple weeks were a bit crazy for many of us. |
Code looks good, well done 👏 Going through some testing now to make sure everything works on both browsers. |
Great. I tested and the new functionality works on Firefox and there are no regressions. The Chrome options popup doesn't work, but this can be handled in a different PR in the future. |
This will be included in version |
Cool, already got the update. 👍 I'll check the options popup issue in Chrome next week. |
@berzniz I took a look on the options popup on Chrome, and it worked like charm to me. I could modify the settings and the were applied after a tab refresh. The chrome version was |
In this PR
Screenshots
Firefox left-click popup
Firefox right-click menu
Firefox extension settings
Firefox options from PR tree
Chrome left-click popup