Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing types #175

Open
oliv-tree opened this issue Jan 12, 2024 · 3 comments
Open

Missing types #175

oliv-tree opened this issue Jan 12, 2024 · 3 comments

Comments

@oliv-tree
Copy link

Hey,

Perhaps this has not been implemented, but I don't seem to be able to get any types when using this library?

E.g., if I do the below I do not get any hints on what is returned by this query.

let profile = await wowClient.characterPVP({
  realm: "silvermoon",
  name: "abc",
})
console.log(profile.data.)
@benweier
Copy link
Owner

Hey @oliv-tree, unfortunately providing all the response types isn't a specific goal as the effort to implement and maintenance to stay on top of it is too much for me to be able to commit to. The class methods are generic, however, and you're able to easily declare the response types for whatever method you need in your project.

let profile = await wowClient.characterPVP<CharacterPvpResponseType>({
  realm: "silvermoon",
  name: "abc",
})

If the library was enough demand or a willing contributor opened a PR I'd be happy to include the types, but unfortunately it's not something I can guarantee personally

@oliv-tree
Copy link
Author

oliv-tree commented Jan 13, 2024

Good to know it wasn't on my end at least.

If the library was enough demand or a willing contributor opened a PR I'd be happy to include the types, but unfortunately it's not something I can guarantee personally

Understandable. Honestly something AI is pretty ideal for.

@benweier
Copy link
Owner

That's an excellent point and I'll look into what kind of results I can get from AI tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants