Allow empty input, consider it "now" #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
A friendly ping @benoitzohar 🙂 |
benoitzohar
requested changes
Nov 2, 2017
src/index.js
Outdated
| @@ -15,73 15,71 @@ const plugin = ({ term, display, actions }) => { | |||
|
|
|||
| //fall back on the ts prefix | |||
| if (!match) { | |||
| match = term.match(/^tsu?\s(.*)/); | |||
| match = term.match(/^tsu?\s*($|.*)/); | |||
There was a problem hiding this comment.
Can you explain why you changed the regex?
I'm under the impression that the first * will catch everything, so the change after it won't affect anything.
There was a problem hiding this comment.
Sure - the old regex requires at least one space, i.e. ts_, the new regex works with plain ts - I simply thought it would be neater 🙂
There was a problem hiding this comment.
Then I guess ^tsu?\s?(.*) would be enough to handle that case
There was a problem hiding this comment.
Indeed, let me quickly adapt
| } | ||
|
|
||
| if (match) { | ||
| const isUTC = term.startsWith('tsu'); | ||
| const input = match[1]; | ||
|
|
||
| if (input) { |
There was a problem hiding this comment.
for me this would be enough to achieve what you want (which I wanted to do in the first place, don't know why I forgot to test it)
benoitzohar
approved these changes
Nov 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And one more improvement, allow just typing
tsortsuwhen I want to get thenow- typingts nowis just too many characters 🙂Review this code ignoring whitespaces: link