Add tsu prefix to use UTC time zone
#6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximbaz
commented
Oct 15, 2017
| break | ||
| case INPUT_FORMAT.TS_MS: | ||
| return moment.unix(parseInt(input) / 1000) | ||
| result = moment.unix(parseInt(input) / 1000) |
There was a problem hiding this comment.
this needs to be done for nanoseconds as well
There was a problem hiding this comment.
#5 has been merged, you can now do it for nanoseconds.
Thanks!
benoitzohar
approved these changes
Oct 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on my project, besides missing nanoseconds precision I often needed timestamps to be parsed in UTC time zone. I'm tired of manually converting that in my head 🙂