-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--limit-request-line check default to MAX_REQUEST_LINE #3171
Comments
Linking commit d79ff99 and comment b7b0979#r2629719 for easier inquiry into why it was swapped around. Imho capping both lower and upper bound are wrong, we should just respect what was configured - using a default >=8000 only if unset. |
Completely agree with you @pajod and I think that's what we should head for. |
well this has been done on purpose 12 years ago to ensure we can't receive too large lines. But I agree it should be a default now instead of beeing a hard limitation. |
Increasing the limit request line above the
MAX_REQUEST_LINE
will default toMAX_REQUEST_LINE
.https://github.com/benoitc/gunicorn/blob/88fc4a43152039c28096c8ba3eeadb3fbaa4aff9/gunicorn/http/message.py#L249C9-L253C55
This is an issue because the other option is to set the
limit_request_line
to0
to make it unlimited. Is this configuration aimed to be0
or less thanMAX_REQUEST_LINE
?Can a higher limit be set as in Nginx? If so, I would be happy to submit a PR.
The text was updated successfully, but these errors were encountered: