Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: menambahkan materi fungsi #12

Merged
merged 2 commits into from
Oct 8, 2021
Merged

add: menambahkan materi fungsi #12

merged 2 commits into from
Oct 8, 2021

Conversation

alvinzf
Copy link
Contributor

@alvinzf alvinzf commented Oct 5, 2021

Menambahkan materi baru -> Fungsi

Deskripsi (Description)

  • saya menambahkan algoritma terbaru
  • saya memperbaiki algoritma yang sudah ada
  • saya memperbaiki dokumentasi
  • saya menambah dokumentasi

Syarat Kontributor (Contributor Requirements)

  • saya sudah membaca (i have read) dan sudah menyetujui (agree) semua yang ada di CONTRIBUTING
  • saya telah menambahkan docs yang memberikan penjelasan maksud dari kode yang saya buat
  • saya menggunakan bahasa indonesia untuk memberikan penjelasan dari kode yang saya buat

Lingkungan (Environment)

saya menggunakan (im used):

  • versi Dart terbaru

Testing

  • analyze lint Dart
  • doctesting Dart

Maintainer

request maintainer untuk mereiview kode kamu usahakan kamu memilih sesuai apa yang telah kamu ubah

maintainer dart
@bellshade/dart-team

maintainer dokumentasi
@bellshade/docs-team

[ID ] Jika ada gagal pada salah satu test kami akan mengeceknya kembali

[EN] If there is a failure in one of the tests we will check it again

@auto-add-label auto-add-label bot added the add label Oct 5, 2021
@zalviandyr
Copy link
Contributor

Terima kasih sudah berkontribusi di Bellshade.

@aditjoos aditjoos added the enhancement New feature or request label Oct 6, 2021
@aditjoos aditjoos linked an issue Oct 6, 2021 that may be closed by this pull request
Function #8
Closed
aditjoos
aditjoos suggested changes Oct 6, 2021
View reviewed changes
basic/8_fungsi/fungsi.dart Outdated

//garis pembatas
print("==============");
// memanggil fungsi hitungUsia
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bisa dijelaskan juga jika fungsi yang dipanggil mengembalikan sebuah nilai int lalu disimpan ke variabel usia agar mudah dimengerti oleh beginner yang belajar 👍

@aditjoos aditjoos requested a review from a team October 6, 2021 15:57
nomadkode
nomadkode approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@nomadkode nomadkode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dokumentasi aman, tidak ada typo. docs LGTM 🚀

Terima kasih @VyscoZyza telah berkontribusi di bellshade. 👍🏼

@nomadkode nomadkode requested a review from aditjoos October 7, 2021 04:55
aditjoos
aditjoos approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@aditjoos aditjoos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Halo, terimakasih telah berkontribusi 👏👏

@aditjoos aditjoos merged commit 2c3c7f9 into bellshade:main Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomadkode nomadkode nomadkode approved these changes

@zalviandyr zalviandyr zalviandyr approved these changes

@aditjoos aditjoos aditjoos approved these changes

Assignees

@alvinzf alvinzf

Labels
add enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Function
4 participants
@alvinzf @zalviandyr @aditjoos @nomadkode