Row and column slice getter #55
Open
362
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@becheran Any chance this can be merged sometime soon? |
becheran
requested changes
Aug 31, 2024
| let start = row_usize * self.cols; | ||
| Some(self.data[start..(start self.cols)].as_ref()) | ||
| } else { | ||
| None |
There was a problem hiding this comment.
I had a look at the changes. Thanks for the formatting. I better setup my auto-formatter better.
I wonder if the implementaiton helps or is more confusing. I don't think it is a good idea to expose a function called get_row which only works in RowMajor mode.
Why not use the already existing iter_row funciton instead and let the caller decide if collecting the result into a Vec is desired?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
get_rowandget_colfunctions to access the corresponding underlying slice of a selected row/column, returningNoneif out of bounds or if the values are not contiguous (e.g., a row from a grid inOrder::ColumnMajoror a column from a grid inOrder::RowMajor).Equivalent mutable methods
get_mut_rowandget_mut_col.EXTRA: some quick linter fixes.