add :focus-visible global styles with polyfill #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for brittanychiang ready! 🔨 Explore the source changes: cc18294 🔍 Inspect the deploy log: https://app.netlify.com/sites/brittanychiang/deploys/615ad657349cfb00082dd446 😎 Browse the preview: https://deploy-preview-165--brittanychiang.netlify.app |
gupta-ji6
changed the title
eloraschoerverth
pushed a commit
to eloraschoerverth/eloraschoerverth.github.io
that referenced
this pull request
Nov 6, 2021
mechakin
pushed a commit
to mechakin/portfolio
that referenced
this pull request
Oct 16, 2023
…fill add :focus-visible global styles with polyfill
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
You already have a default
:focusstyle inGlobalStyle.js. This PR adds the new:focus-visiblestyle, which only adds focus styles when the user navigates with the keyboard, not the mouse.Screenshots
Before
After
References
:focus-visibleand backwards compatibilityLive Test
I use these styles in my portfolio, you can test how this works here for a quick look.
P.S.
Thank you for building such a great portfolio and open souring it :)
I totally understand if these changes don't suit your needs. I raised a PR thinking it might be a good add-on. I will happy to if I contributed to something I have been using myself for a long time.