Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSON ParserError with kamal secrets extract $SECRETS #1284

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix JSON ParserError with kamal secrets extract $SECRETS #1284

wants to merge 1 commit into from
11 −1

Conversation

chrisdebruin
Copy link
Contributor

When running kamal secrets extract TEST $SECRETS and value of TEST contains a ( the code was throwing a JSON::ParserError

secrets = { TEST: "value(" }.to_json.shellescape
JSON.parse(secrets)

@chrisdebruin chrisdebruin force-pushed the fix-secrets-with-special-chars branch from 493c9d8 to 3c9fd1b Compare December 11, 2024 13:20
@djmb
Copy link
Collaborator

djmb commented Dec 13, 2024

This feels like a problem with the output from kamal secrets fetch command rather than something to fix in the extract command. Do you know why the output is escaped like this?

@chrisdebruin
Copy link
Contributor Author

This feels like a problem with the output from kamal secrets fetch command rather than something to fix in the extract command. Do you know why the output is escaped like this?

Yes it's because of fetch is doing a shellescape on the json data. In this case the ( is also escaped even though it is inside ""

{ TEST: "value(" }.to_json.shellescape => "\\{\\\"TEST\\\":\\\"value\\(\\\"\\}"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisdebruin @djmb