[7.0] Remove quotes option #5154
Conversation
existentialism
added
the
PR: Breaking Change 💥
|
Hey @4rlekin! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time. |
Codecov Report@@ Coverage Diff @@
## 7.0 #5154 /- ##
==========================================
- Coverage 89.61% 89.61% -0.01%
==========================================
Files 200 200
Lines 9753 9752 -1
Branches 2597 2596 -1
==========================================
- Hits 8740 8739 -1
Misses 1013 1013
Continue to review full report at Codecov.
|
| @@ -58,7 58,6 @@ function normalizeOptions(code, opts, tokens): Format { | |||
| compact: opts.compact, | |||
| minified: opts.minified, | |||
| concise: opts.concise, | |||
| quotes: opts.quotes || findCommonStringDelimiter(code, tokens), | |||
There was a problem hiding this comment.
Do we want to keep findCommonStringDelimiter? If we do we then this pr can just be removing opts.quotes rather than defaulting to double.
I wasn't sure at the time
There was a problem hiding this comment.
Yeah, I guess we never really decided if we wanted to default to double or infer. The more I think about it, I think infer is better option?
There was a problem hiding this comment.
@4rlekin Can we just remove the top level quotes option? Basically I think we can just do quotes: findCommonStringDelimiter(code, tokens), so that it still runs findCommonStringDelimiter. Basically we just need to not allow the user to specify the quotes and rather we infer it.
|
Provided Travis build will go without issue it should be all good now, sorry for the delay. |
|
Hey @4rlekin! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time. |
|
Hmm... i swear to god i re-generated those exact tests, dunno why it fails, could someone check this out ? |
|
yeah I'l check out |
|
I think you can just remove the last commit and it should be good because tests are the same as before (with the new change of just removing the option) |
|
Thanks @4rlekin I just rebased and removed the test fixture changes since they weren't needed anymore |
* 7.0: (37 commits) resolved conflicts [7.0] Switch decorators-legacy to decorators in the Stage 1 Preset (babel#5318) (babel#5319) [7.0] Replacing current decorators with decorators-legacy (babel#5290) Add Node 7 to CI (babel#5165) [7.0] remove standalone babel package (babel#5293) .gitignore for test [skip ci] update yarn use [email protected] (babel#5254) [7.0] Run Babel's unittests in a custom sandbox (take 2). (babel#5263) [7.0] Remove quotes option (babel#5154) [7.0] List babylon plugins instead of * in babel-generator tests (babel#5231) Remove babel-runtime from packages' dependencies (babel#5218) Bump `detect-indent`. (babel#5226) [7.0] Add legacy-decorators to stage-1. Fixes babel#5220 (babel#5225) [7.0] Use lerna's --independent mode changes (fixes babel#5221) [7.0] Bump `home-or-tmp` for `babel-register`. (babel#5189) [7.0] Added yarn.lock (babel#5175) [7.0] Remove old babel-runtime code (babel#5187) [7.0] Drop support for Node 5 (babel#5186) Remove path-is-absolute in favor of builtin path.isAbsolute (babel#5179) ...
lock
bot
added
the
outdated
quotesoption in babel-generator doesn't exist anymore, so yesAll details in commit messages (probably more than is really needed)