-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove node 0.10 support (CI) #5041
Conversation
Current coverage is 89.15% (diff: 100%)@@ master #5041 diff @@
==========================================
Files 203 203
Lines 9821 9821
Methods 1072 1072
Messages 0 0
Branches 2614 2614
==========================================
Hits 8756 8756
Misses 1065 1065
Partials 0 0
|
If node 4 is the new minimum, then node 0.12 should be dropped from |
Our concern is that while 0.10 is unsupported from the node devs, to me that doesn't necessarily mean that it's fine to drop support for it without a major version, since it's still a breaking change, even if the version that broke is outside the Node team's support range. |
@zertosh node 0.12 support is removed in the PR #5025 ( @loganfsmyth It will of course require a major release. I added it to the milestone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change to doc, but otherwise LGTM
|
||
The Babel compiler is **only** supported in these environments: | ||
|
||
- Modern browsers such as Chrome, Firefox, Safari, Edge etc. | ||
- Node 0.10 | ||
- Node 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Node 4 (Unlikely but people might interpret this as Node 4 only)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we’re nitpicking anyway: the proper name is “Node.js”, not Node
@@ -17,7 17,6 @@ to: | |||
- Rhino | |||
- Nashorn | |||
- Internet Explorer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that just "Internet Explorer" is vast (http://babeljs.io/docs/usage/caveats/#internet-explorer). Do you know which versions we could support officialy? Edge?
Related to #5025 (Drop support for Node 0.12 💀)
Dropping support is a breaking change, it will require a major release of Babel.