Correctly print parens around in in for heads
#16630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57311 |
| inForStatementInit: boolean = false; | ||
| enterForStatementInit(val: boolean) { | ||
| const old = this.inForStatementInit; | ||
| if (old === val) return () => {}; |
There was a problem hiding this comment.
Maybe return undefined and then use exit?.() on the caller?
There was a problem hiding this comment.
Isn't it better to use consistent types, rather than having polymorphic functions? It's trivial for an engine to optimise an empty function call.
JLHwung
approved these changes
Jul 11, 2024
liuxingbaoyu
approved these changes
Jul 11, 2024
|
Interesting PR! I wanted to test it, but link from @babel-bot fails with:
|
|
CircleCI has been working weirdly in the past few days, thanks for noticing the problem -- I'll see if it something that we need to fix :) |
|
It seems that the CircleCI API no longer allows cross-domain. |
brandonb927
pushed a commit
to brandonb927/brandonb-sites
that referenced
this pull request
Jul 23, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@babel/preset-env](https://babel.dev/docs/en/next/babel-preset-env) ([source](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env)) | dependencies | patch | [`7.24.7` -> `7.24.8`](https://renovatebot.com/diffs/npm/@babel/preset-env/7.24.7/7.24.8) | --- ### Release Notes <details> <summary>babel/babel (@​babel/preset-env)</summary> ### [`v7.24.8`](https://github.com/babel/babel/blob/HEAD/CHANGELOG.md#v7248-2024-07-11) [Compare Source](babel/babel@v7.24.7...v7.24.8) ##### 👓 Spec Compliance - `babel-parser` - [#​16567](babel/babel#16567) Do not use strict mode in TS `declare` ([@​liuxingbaoyu](https://github.com/liuxingbaoyu)) ##### 🐛 Bug Fix - `babel-generator` - [#​16630](babel/babel#16630) Correctly print parens around `in` in `for` heads ([@​nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - [#​16626](babel/babel#16626) Fix printing of comments in `await using` ([@​nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - [#​16591](babel/babel#16591) fix typescript code generation for yield expression inside type expre… ([@​SreeXD](https://github.com/SreeXD)) - `babel-parser` - [#​16613](babel/babel#16613) Disallow destructuring assignment in `using` declarations ([@​H0onnn](https://github.com/H0onnn)) - [#​16490](babel/babel#16490) fix: do not add `.value: undefined` to regexp literals ([@​liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-types` - [#​16615](babel/babel#16615) Remove boolean props from `ObjectTypeInternalSlot` visitor keys ([@​nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-plugin-transform-typescript` - [#​16566](babel/babel#16566) fix: Correctly handle `export import x =` ([@​liuxingbaoyu](https://github.com/liuxingbaoyu)) ##### 💅 Polish - `babel-generator` - [#​16625](babel/babel#16625) Avoid unnecessary parens around `async` in `for await` ([@​nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-traverse` - [#​16619](babel/babel#16619) Avoid checking `Scope.globals` multiple times ([@​liuxingbaoyu](https://github.com/liuxingbaoyu)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Reviewed-on: https://git.brandonb.ca/brandon/personal-sites/pulls/3 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
brandonb927
pushed a commit
to brandonb927/brandonb-sites
that referenced
this pull request
Jul 23, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@babel/core](https://babel.dev/docs/en/next/babel-core) ([source](https://github.com/babel/babel/tree/HEAD/packages/babel-core)) | dependencies | patch | [`7.24.7` -> `7.24.9`](https://renovatebot.com/diffs/npm/@babel/core/7.24.7/7.24.9) | --- ### Release Notes <details> <summary>babel/babel (@​babel/core)</summary> ### [`v7.24.9`](https://github.com/babel/babel/blob/HEAD/CHANGELOG.md#v7249-2024-07-15) [Compare Source](babel/babel@v7.24.8...v7.24.9) ##### 🐛 Bug Fix - `babel-core`, `babel-standalone` - [#​16639](babel/babel#16639) Avoid `require()` call in `@babel/standalone` bundle ([@​nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-types` - [#​16638](babel/babel#16638) fix: provide legacy typings for TS < 4.1 ([@​JLHwung](https://github.com/JLHwung)) ##### 💅 Polish - `babel-generator`, `babel-plugin-transform-optional-chaining` - [#​16617](babel/babel#16617) Avoid extra parens in TS `as`/`satisfies` ([@​nicolo-ribaudo](https://github.com/nicolo-ribaudo)) ##### 🏠 Internal - `babel-helper-module-transforms` - [#​16629](babel/babel#16629) Lazy top-level initializations for module transforms ([@​guybedford](https://github.com/guybedford)) ### [`v7.24.8`](https://github.com/babel/babel/blob/HEAD/CHANGELOG.md#v7248-2024-07-11) [Compare Source](babel/babel@v7.24.7...v7.24.8) ##### 👓 Spec Compliance - `babel-parser` - [#​16567](babel/babel#16567) Do not use strict mode in TS `declare` ([@​liuxingbaoyu](https://github.com/liuxingbaoyu)) ##### 🐛 Bug Fix - `babel-generator` - [#​16630](babel/babel#16630) Correctly print parens around `in` in `for` heads ([@​nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - [#​16626](babel/babel#16626) Fix printing of comments in `await using` ([@​nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - [#​16591](babel/babel#16591) fix typescript code generation for yield expression inside type expre… ([@​SreeXD](https://github.com/SreeXD)) - `babel-parser` - [#​16613](babel/babel#16613) Disallow destructuring assignment in `using` declarations ([@​H0onnn](https://github.com/H0onnn)) - [#​16490](babel/babel#16490) fix: do not add `.value: undefined` to regexp literals ([@​liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-types` - [#​16615](babel/babel#16615) Remove boolean props from `ObjectTypeInternalSlot` visitor keys ([@​nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-plugin-transform-typescript` - [#​16566](babel/babel#16566) fix: Correctly handle `export import x =` ([@​liuxingbaoyu](https://github.com/liuxingbaoyu)) ##### 💅 Polish - `babel-generator` - [#​16625](babel/babel#16625) Avoid unnecessary parens around `async` in `for await` ([@​nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-traverse` - [#​16619](babel/babel#16619) Avoid checking `Scope.globals` multiple times ([@​liuxingbaoyu](https://github.com/liuxingbaoyu)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Reviewed-on: https://git.brandonb.ca/brandon/personal-sites/pulls/2 Reviewed-by: brandon <brandon [email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
This was referenced Aug 1, 2024
This was referenced Aug 1, 2024
This was referenced Sep 11, 2024
This was referenced Sep 11, 2024
This was referenced Sep 11, 2024
This was referenced Sep 12, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really wanted to use
using, but we would need an assumption to avoid the try/catch when we know it's not necessary.