Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript 3.4 meta-issue #9502

Closed
2 tasks done
DanielRosenwasser opened this issue Feb 13, 2019 · 10 comments · Fixed by #9534
Closed
2 tasks done

TypeScript 3.4 meta-issue #9502

DanielRosenwasser opened this issue Feb 13, 2019 · 10 comments · Fixed by #9534
Labels
area: typescript help wanted outdated A closed issue/PR that is archived due to age. Recommended to make a new issue spec-update
Milestone

Comments

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Feb 13, 2019

TypeScript 3.4 will be introducing a number of syntactic additions in the type space as well as the expression space.

Our target date for the release of TypeScript 3.4 is around the end of March 2019.

@danez
Copy link
Member

danez commented Feb 13, 2019

I tried parsing this with babel let x = 10 as const; and it doesn't work afaics. How did you make it work?

Unexpected token (1:14)

> 1 | let x = 10 as const;
                    ^

@DanielRosenwasser
Copy link
Member Author

DanielRosenwasser commented Feb 13, 2019

You might be right - the online repl seems like it doesn't work with TypeScript for some reason.

@nicolo-ribaudo
Copy link
Member

Doesn't the "Add plugin" button in the plugins section of the sidebar work for you?

@DanielRosenwasser
Copy link
Member Author

DanielRosenwasser commented Feb 14, 2019

Nope :(

Plugin @babel/plugin-transform-typescript could not be loaded

Seems like it's trying to eval the HTML on https://bundle.run/@babel/[email protected]?

@danez
Copy link
Member

danez commented Feb 18, 2019

@DanielRosenwasser should we wait with releasing any of this changes till typescript 3.4 is out/close to being released?

@Jessidhia
Copy link
Member

My intuition is that as soon as the 3.4.0 version is released it should be safe to release. TypeScript typically doesn't declare .0 versions stable, though, they refer to them as "RC"; but I don't think there's any precedent for them breaking grammar or emit semantics after having released a .0 version.

@typescript-eslint/parser always waits until the .1 version (the one that gets the "stable version released" publicity) is out which tbh is rather inconvenient.


@DanielRosenwasser would I be correct in my understanding that the .0 version is intended to be supported by tooling and typing authors, and the "delay" before making it "stable" is to give some time for the ecosystem to catch up? Or should it just be treated like an oddly-named beta?

@DanielRosenwasser
Copy link
Member Author

DanielRosenwasser commented Mar 7, 2019

Well there's typically about 2 weeks in between an RC and a release. I would just wait until TS 3.4 goes out to publish anything with this functionality. If you want to let stuff "bake" in nightly releases, that's probably a good idea and you can merge some PRs in.

@nicolo-ribaudo
Copy link
Member

We usually don't do nightly releases, we just wait to merge PRs if needed since it is much simpler 😆

@ulrichb
Copy link

ulrichb commented Mar 30, 2019

So, is this released with plugin-transform-typescript 7.4.0? ... I get "SyntaxError: Unexpected token" for both, readonly tuples and as const literals...

@ulrichb
Copy link

ulrichb commented Mar 30, 2019

Okay, forget it. I don't know why, but I had an outdated indirect @babel/parser package (< 7.4).

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 1, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: typescript help wanted outdated A closed issue/PR that is archived due to age. Recommended to make a new issue spec-update
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants