Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor transform-classes #7202

Closed
Andarist opened this issue Jan 11, 2018 · 1 comment · Fixed by #7444
Closed

Refactor transform-classes #7202

Andarist opened this issue Jan 11, 2018 · 1 comment · Fixed by #7444
Labels
i: discussion outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish 💅 A type of pull request used for our changelog categories

Comments

@Andarist
Copy link
Member

At the moment transform-classes has 2 modes - regular one and loose. The loose mode is extending VanillaTransformer class. It seems to me that this hierarchical structure here is clunky and harder to maintain.

Don't know how others feel, but imho it would be nice to refactor this into a flat structure and reuse code between 2 transforms if possible, but more in a composition manner than with inheritance.

I'd like to have at least 2-3 upvotes from other core team members for this, before anyone starts to work on this.
@Andarist Andarist added the PR: Polish 💅 A type of pull request used for our changelog categories label Jan 11, 2018
@babel-bot
Copy link
Collaborator

Hey @Andarist! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community that typically always has someone willing to help. You can sign-up here
for an invite.

@Andarist Andarist added i: discussion and removed PR: Polish 💅 A type of pull request used for our changelog categories labels Jan 11, 2018
@Andarist Andarist mentioned this issue Jan 11, 2018
Closed
@thymikee thymikee mentioned this issue Feb 27, 2018
Merged
@xtuc xtuc added the PR: Polish 💅 A type of pull request used for our changelog categories label Mar 21, 2018
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 20, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
i: discussion outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor inheritance in babel-plugin-transform-classes thymikee/babel
3 participants
@xtuc @Andarist @babel-bot