Is it time to stop using `createElement` in JSX new transform now? #15509

magic-akari · 2023-03-22T16:37:11Z

magic-akari
Mar 22, 2023

babel/packages/babel-plugin-transform-react-jsx/src/create-plugin.ts

Lines 362 to 385 in 1584512

 // We want to use React.createElement, even in the case of 

 // jsx, for <div {...props} key={key} /> to distinguish it 

 // from <div key={key} {...props} />. This is an intermediary 

 // step while we deprecate key spread from props. Afterwards, 

 // we will stop using createElement in the transform. 

 function shouldUseCreateElement(path: NodePath<JSXElement>) { 

 const openingPath = path.get("openingElement"); 

 const attributes = openingPath.node.attributes; 

 let seenPropsSpread = false; 

 for (let i = 0; i < attributes.length; i ) { 

 const attr = attributes[i]; 

 if ( 

 seenPropsSpread && 

 t.isJSXAttribute(attr) && 

 attr.name.name === "key" 

 ) { 

 return true; 

 } else if (t.isJSXSpreadAttribute(attr)) { 

 seenPropsSpread = true; 

 } 

 } 

 return false; 

 }

I come from swc-project/swc#6987 (comment).

I have noticed a certain comment in the source code of Babel.

I would like to inquire whether a specific React version requires such intermediary steps.

Is it time to stop using createElement now?

nicolo-ribaudo · 2023-03-22T22:25:44Z

nicolo-ribaudo
Mar 22, 2023
Maintainer

I think we should ask to the React team

@gaearon

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Is it time to stop using `createElement` in JSX new transform now? #15509

{{title}}

Replies: 1 comment

{{title}}

Select a reply

Is it time to stop using createElement in JSX new transform now? #15509

magic-akari Mar 22, 2023

Replies: 1 comment

nicolo-ribaudo Mar 22, 2023 Maintainer

Is it time to stop using `createElement` in JSX new transform now? #15509

magic-akari
Mar 22, 2023

nicolo-ribaudo
Mar 22, 2023
Maintainer