Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add PLAYER_EVENT_ON_QUEST_REWARD_ITEM, add PLAYER_EVENT_ON_CREATE_ITEM, add PLAYER_EVENT_ON_STORE_NEW_ITEM #88

Merged
merged 6 commits into from
Jan 30, 2023

Conversation

veserine
Copy link

add PLAYER_EVENT_ON_QUEST_REWARD_ITEM
add PLAYER_EVENT_ON_CREATE_ITEM
add PLAYER_EVENT_ON_STORE_NEW_ITEM

add PLAYER_EVENT_ON_QUEST_REWARD_ITEM
add PLAYER_EVENT_ON_CREATE_ITEM
add PLAYER_EVENT_ON_STORE_NEW_ITEM
Copy link
Member

@r-o-b-o-t-o r-o-b-o-t-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Could you please do the following:

  • Add a description of your changes to the README file (example)
  • Add a line to RegisterPlayerEvent's doc comment (basically the lines you added to Hooks.h but as comment lines, example)
  • Take a look at my code suggestions, they're just line breaks so not very important but let's try to keep things consistent if possible 😄

src/ElunaLuaEngine_SC.cpp Show resolved Hide resolved
src/ElunaLuaEngine_SC.cpp Show resolved Hide resolved
src/LuaEngine/PlayerHooks.cpp Show resolved Hide resolved
veserine and others added 5 commits January 28, 2023 06:15
update README.md under the pulling rule.
updated README_CN.md and GLOBALMETHODS_H under the pulling rule.
@r-o-b-o-t-o r-o-b-o-t-o merged commit 695c6b7 into azerothcore:master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants