Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Child of #1773] Update Storybook to version 6 [Due Date: 03.08.20] #1774

Closed
danyball opened this issue May 15, 2020 · 4 comments · Fixed by #1926
Closed

[Child of #1773] Update Storybook to version 6 [Due Date: 03.08.20] #1774

danyball opened this issue May 15, 2020 · 4 comments · Fixed by #1926
Assignees
@danyball
Labels
Accepted A feature request or issue is accepted and will be implemented Feature-request

Comments

@danyball
Copy link
Contributor

We dont want to redesign storybook on a old version to avoid doubled work. The updated causes some breaking changes and we want to fix them first.
This was referenced May 15, 2020
Closed
Closed
@danyball danyball mentioned this issue May 29, 2020
Closed
@raphaellueckl raphaellueckl mentioned this issue Jun 24, 2020
Closed
9 tasks
@raphael-suter raphael-suter removed their assignment Jul 1, 2020
@LucaMele LucaMele added the Accepted A feature request or issue is accepted and will be implemented label Jul 8, 2020
@raphaellueckl raphaellueckl self-assigned this Jul 9, 2020
@raphaellueckl raphaellueckl mentioned this issue Jul 9, 2020
Closed
@danyball
Copy link
Contributor Author

danyball commented Jul 13, 2020 •
edited
Loading

Something not working with 5.3 internally:

TypeError: Invalid attempt to spread non-iterable instance
   at _nonIterableSpread (http://localhost:6006/vendors~main.133d19674bf184295530.bundle.js:14402:33)
   at _toConsumableArray (http://localhost:6006/vendors~main.133d19674bf184295530.bundle.js:14400:36)
   at Anonymous function (http://localhost:6006/vendors~main.133d19674bf184295530.bundle.js:14858:7)
   at render (http://localhost:6006/vendors~main.133d19674bf184295530.bundle.js:11859:13)
   at configure (http://localhost:6006/vendors~main.133d19674bf184295530.bundle.js:11894:9)
   at configure (http://localhost:6006/vendors~main.133d19674bf184295530.bundle.js:14983:5)
   at configure (http://localhost:6006/vendors~main.133d19674bf184295530.bundle.js:24887:3)
   at Anonymous function (http://localhost:6006/main.133d19674bf184295530.bundle.js:246:1)
   at ./.storybook/generated-entry.js (http://localhost:6006/main.133d19674bf184295530.bundle.js:242:29)
   at __webpack_require__ (http://localhost:6006/runtime~main.133d19674bf184295530.bundle.js:849:12)

generated-entry.js:

import { configure } from '@storybook/html';
              module._StorybookPreserveDecorators = true;

              configure([require.context('../src/components', true, /^\.\/(?:(?:|\/|(?:(?:(?!(?:|\/)\.).)*?)\/)story\.js)$/)
              ], module);

--> configure could be the problem internally?!

Next step: Try updating to SB 6 Beta

@danyball
Copy link
Contributor Author

Because of successful upgrading to SB 6.X RC we are waiting till the 6 final release. A good starting point to upgrade is this branch: feature/update-storybook-5-3.

Due date to upgrade: storybookjs/storybook#9311

@danyball danyball changed the title [Child of #1773] Update Storybook to the latest version [Child of #1773] Update Storybook to the latest version [Due Date: 31.07.20] Jul 14, 2020
@danyball danyball changed the title [Child of #1773] Update Storybook to the latest version [Due Date: 31.07.20] [Child of #1773] Update Storybook to version 6 [Due Date: 31.07.20] Jul 14, 2020
@danyball danyball mentioned this issue Jul 15, 2020
Closed
@raphael-suter raphael-suter mentioned this issue Jul 24, 2020
Closed
@danyball danyball changed the title [Child of #1773] Update Storybook to version 6 [Due Date: 31.07.20] [Child of #1773] Update Storybook to version 6 [Due Date: 03.08.20] Jul 24, 2020
@raphael-suter
Copy link
Contributor

Please have a look at #1898 after the update.

@danyball danyball mentioned this issue Jul 27, 2020
Closed
@danyball danyball self-assigned this Aug 18, 2020
@danyball
Copy link
Contributor Author

WARN Found 5 outdated packages (relative to '@storybook/[email protected]')
WARN Please make sure your packages are updated to ensure a consistent experience.
WARN - @storybook/[email protected]
WARN - @storybook/[email protected]
WARN - @storybook/[email protected]
WARN - @storybook/[email protected]
WARN - @storybook/[email protected]

@danyball danyball mentioned this issue Aug 19, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danyball danyball

Labels
Accepted A feature request or issue is accepted and will be implemented Feature-request
Projects
None yet
Milestone
No milestone
4 participants
@LucaMele @danyball @raphaellueckl @raphael-suter