Fine-tune the Ordering for changed_blocks_count #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbgbt
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Thanks for your contribution! I agree that Relaxed ordering is still correct here since we don't synchronize access to other data based on the counter.
As separate feedback, do you mind making modifying the commit message? Something more specific like this would be great:
Use relaxed ordering for atomic block change counter
wang384670111
force-pushed
the
tune_ordering
branch
from
d0955e5
to
aa9133e
Compare
I've made the necessary changes to the commit information. May I inquire about the possibility of merging this pull request at your earliest convenience? |
jpculp
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coldsnap/src/upload.rs
Line 221 in a60762c
coldsnap/src/upload.rs
Line 400 in a60762c
Here
changed_blocks_countis employed solely for counting purposes, rather than for synchronizing access to other shared variables. WhileSeqCstguarantees program correctness, it can also impact performance. Therefore, usingRelaxedis sufficient to maintain the program's correctness without adversely affecting its efficiency.