Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Shift environment variables to parameter store #231

Open
flamingquaks opened this issue Nov 21, 2023 · 0 comments
Open

Chore: Shift environment variables to parameter store #231

flamingquaks opened this issue Nov 21, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@flamingquaks
Copy link
Collaborator

Currently, Lambda functions leverage environment variables for many of the configurations.
Because majority of the logic is handled in genai_core, it somewhat hides what environment variables would need to be attached to a lambda.

If more functions are introduced, this requires each of these functions to have environment variables attached for code that isn't living in the main handler. Additionally, if genai_core logic is changed and requires new/different variables, the lambda that is calling the genai_core code would have to be updated or would break.

Proposal
Shifting to parameter store for these values allows genai_core packages to retrieve the configurations without requiring the lambda function to have environment variables maintained. Lambdas would simply need to have access to the configuration.

@massi-ang massi-ang added the enhancement New feature or request label Dec 15, 2023
@massi-ang massi-ang self-assigned this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants