Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: npm run deploy triggers large volume of code formatting changes #230

Open
flamingquaks opened this issue Nov 21, 2023 · 2 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@flamingquaks
Copy link
Collaborator

Currently, I'm leveraging npm run deploy for the CDK deployment. As part of the call, the command executes npm run format first, which handles file formatting.

When the command executes, I'm seeing formatting changes being applied to many files, even ones I've never touched. While I can discard these changes, it creates a burden if I forget to stage changes I want to keep before running the command.

As a contributor, I worry that I will create bloated commits with changes that aren't necessary.

Can we review the formatting to formatting to avoid this?

Screenshot 2023-11-21 at 08 45 55

Screenshot 2023-11-21 at 08 51 17

Screenshot 2023-11-21 at 08 51 40

@massi-ang massi-ang added bug Something isn't working and removed bug Something isn't working labels Dec 15, 2023
@massi-ang
Copy link
Collaborator

Thanks for reporting this.

Formatting should be done on commit/pr and not on deploy.

@charles-marion
Copy link
Collaborator

Added formatting verification on every change
#526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

3 participants