- Fix: Avoid cache corruption when the returned structure is modified.

- Fix: Avoid cache corruption when the returned structure is modified. Fixes JSONPath-Plus#102. (@tejodorus) Co-authored-by: Brett Zamir <[email protected]>
awlayton · Apr 9, 2021 · 2860830 · 2860830
1 parent 61c654f
commit 2860830
Show file tree

Hide file tree

Showing 11 changed files with 25 additions and 10 deletions.
diff --git a/badges/tests-badge.svg b/badges/tests-badge.svg
diff --git a/dist/index-browser-esm.js b/dist/index-browser-esm.js
@@ -982,7 982,7 @@ JSONPath.toPathArray = function (expr) {
  return !match || !match[1] ? exp : subx[match[1]];
  });
  cache[expr] = exprList;
- return cache[expr];
  return cache[expr].concat();
 };
 
 /**

diff --git a/dist/index-browser-esm.min.js b/dist/index-browser-esm.min.js
diff --git a/dist/index-browser-esm.min.js.map b/dist/index-browser-esm.min.js.map
diff --git a/dist/index-browser-umd.js b/dist/index-browser-umd.js
@@ -988,7 988,7 @@
  return !match || !match[1] ? exp : subx[match[1]];
  });
  cache[expr] = exprList;
- return cache[expr];
  return cache[expr].concat();
  };
 
  /**

diff --git a/dist/index-browser-umd.min.js b/dist/index-browser-umd.min.js
diff --git a/dist/index-browser-umd.min.js.map b/dist/index-browser-umd.min.js.map
diff --git a/dist/index-node-cjs.js b/dist/index-node-cjs.js
@@ -729,7 729,7 @@ JSONPath.toPathArray = function (expr) {
  return !match || !match[1] ? exp : subx[match[1]];
  });
  cache[expr] = exprList;
- return cache[expr];
  return cache[expr].concat();
 };
 
 JSONPath.prototype.vm = vm__default['default'];

diff --git a/dist/index-node-esm.mjs b/dist/index-node-esm.mjs
@@ -721,7 721,7 @@ JSONPath.toPathArray = function (expr) {
  return !match || !match[1] ? exp : subx[match[1]];
  });
  cache[expr] = exprList;
- return cache[expr];
  return cache[expr].concat();
 };
 
 JSONPath.prototype.vm = vm;

diff --git a/src/jsonpath.js b/src/jsonpath.js
@@ -699,7 699,7 @@ JSONPath.toPathArray = function (expr) {
  return !match || !match[1] ? exp : subx[match[1]];
  });
  cache[expr] = exprList;
- return cache[expr];
  return cache[expr].concat();
 };
 
 export {JSONPath};
diff --git a/test/test.toPath.js b/test/test.toPath.js
@@ -46,4 46,19 @@ describe('JSONPath - toPath*', function () {
 
  assert.strictEqual(path, originalPath);
  });
 
  it('toPathArray (cache issue)', () => {
  // We test here a bug where toPathArray did not return a clone of the cached
  // array. As a result, the evaluate call corrupted the cached value instead
  // of its local copy.
 
  // Make the path unique by including the test name 'cacheissue' in the path
  // because we do not want it to be in the cache already.
  const expected = ['$', 'store', 'bicycle', 'cacheissue'];
  const path = "$.store['bicycle'].cacheissue";
  const json = {};
  jsonpath({json, path, wrap: false});
  const result = jsonpath.toPathArray(path);
  assert.deepEqual(result, expected);
  });
 });