Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable package-private Getters/Setters/Constructors #251

Merged
merged 10 commits into from
Jun 27, 2024
Merged

Enable package-private Getters/Setters/Constructors #251

merged 10 commits into from
Jun 27, 2024

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Jun 26, 2024 •
edited
Loading

  • Writes all adapters to the same package unless the type is imported.
  • non-final package-private fields can be (de)serialized
  • allow package-private getters/setters/constructors
  • allow non-imported package-private classes to have adapters generated

Fixes #248

@SentryMan SentryMan requested a review from rbygrave June 26, 2024 19:57
@SentryMan SentryMan self-assigned this Jun 26, 2024
@SentryMan SentryMan added the enhancement New feature or request label Jun 26, 2024
@SentryMan SentryMan added this to the 2.0 milestone Jun 26, 2024
@SentryMan SentryMan changed the title Enable Package Private Getters/Setters/Constructors Enable Package Private Classes/Getters/Setters/Constructors Jun 26, 2024
@SentryMan SentryMan changed the title Enable Package Private Classes/Getters/Setters/Constructors Enable package-private Classes/Getters/Setters/Constructors Jun 26, 2024
@SentryMan SentryMan changed the title Enable package-private Classes/Getters/Setters/Constructors Enable package-private Getters/Setters/Constructors Jun 27, 2024
@SentryMan
Copy link
Collaborator Author

SentryMan commented Jun 27, 2024 •
edited
Loading

IDK if it's a JDK bug or what but it seems that I can't reference a pkg-private class from generated sources even though it's in the same package.

EDIT: no wait, validator is working. hmmm

@SentryMan
Copy link
Collaborator Author

I guess you can't use imports with pkg-private classes, you learn something new every day

@SentryMan
Copy link
Collaborator Author

seems cascading works via the module route
image
image

@rbygrave rbygrave merged commit ce85c9c into avaje:main Jun 27, 2024
5 checks passed
@SentryMan SentryMan deleted the package-private branch June 27, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbygrave rbygrave Awaiting requested review from rbygrave

@rob-bygrave rob-bygrave Awaiting requested review from rob-bygrave

Assignees

@SentryMan SentryMan

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

Allow package private members
3 participants
@SentryMan @rob-bygrave @rbygrave