remove current key from queue after sync #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecordell
commented
Aug 31, 2022
| @@ -163,8 163,7 @@ func (c *OwnedResourceController) processNext(ctx context.Context) bool { | |||
| ctx = c.OperationsContext.WithValue(ctx, queue.NewOperations(done, requeue)) | |||
|
|
|||
| c.sync(ctx, *gvr, namespace, name) | |||
|
|
|||
| cancel() | |||
| done() | |||
There was a problem hiding this comment.
done calls cancel already
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you forget to call
doneafter syncing an key, futureAdds to the queue will mark it as dirty without re-adding it to the queue (effectively, the object is processed once until finished, and then never touched again until the operator is restarted).If you're using the
OwnedResourceController, this change makes it so that you don't have to call done from within the sync function; the controller will do it for you after the sync returns.