Add existence checking to adoption handler #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I guess if the controller just did something else with the resource, it can assume it's there. There are definitely race conditions to account for though |
|
You can just |
|
Optional to me means that if you pass a nil for that function it will use a default handler that does that. It's ok if it's only "optional" though. |
jakedt
approved these changes
Sep 9, 2022
ecordell
force-pushed
the
existence-check-adopt
branch
from
2a869b9 to
7d60ace
Compare
ecordell
force-pushed
the
existence-check-adopt
branch
from
7d60ace to
4a7902a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a non-existent object is "adopted", the server-side-apply to label/annotate the object will end up creating an empty object.
This change adds an optional existence check to the adoption handler that can be used to abort the adoption process early if the object doesn't exist.