Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upload condition #68

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Fix upload condition #68

merged 1 commit into from
Nov 19, 2021

Conversation

saimn
Copy link
Contributor

@saimn saimn commented Nov 18, 2021

The 1.1.0 tag does not start with a v. Also for pytest-doctestplus we don't check github.event_name, I don't remember why but it seems useless anyway.

@saimn saimn requested a review from cmccully November 18, 2021 22:17
@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #68 (1833294) into master (3e909d9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #68    /-   ##
=======================================
  Coverage   93.09%   93.09%           
=======================================
  Files           7        7           
  Lines         782      782           
  Branches       12       12           
=======================================
  Hits          728      728           
  Misses         54       54           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e909d9...1833294. Read the comment docs.

@saimn saimn merged commit 0473412 into master Nov 19, 2021
@saimn saimn deleted the saimn-patch-1 branch November 19, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants