feat(cli): add command to perform ics20 withdrawals #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quasystaty1
force-pushed
the
quasystaty1/ENG-904/cli/ics20withdrawal
branch
from
4967960 to
5f58098
Compare
sambukowski
reviewed
Oct 9, 2024
sambukowski
reviewed
Oct 9, 2024
sambukowski
reviewed
Oct 9, 2024
sambukowski
approved these changes
Oct 9, 2024
SuperFluffy
reviewed
Oct 9, 2024
| #[arg(long, default_value = None)] | ||
| pub(crate) bridge_address: Option<Address>, | ||
| #[arg(long, action(ArgAction::SetTrue))] | ||
| pub(crate) use_compact: bool, |
There was a problem hiding this comment.
should have been "compat" for the compatibility addresses. this has been fixed.
SuperFluffy
changed the title
Fraser999
reviewed
Oct 14, 2024
Comment on lines
44
to
46
| /// The address to refund on timeout, if unset refunds the signer | ||
| #[arg(long)] | ||
| return_address: Address, |
There was a problem hiding this comment.
We'd need to make this field an Option to allow it to be unset. Just now, the command will fail if --return-address is not specified.
There was a problem hiding this comment.
Should we set the return address to the sender address by default if --return-address is not specified?
There was a problem hiding this comment.
Makes sense to me, yes. But if others disagree, we need to update the comment to not say ", if unset refunds the signer".
Fraser999
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds Ics20Withdrawal command to the cli for Ics20Withdrawal action
Background
part of adding all sequencer actions as cli commands.
Changes
astria-cli sequencer ics20-withdrawalcommandTesting
Related Issues
part of #1474
closes #1623