Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: ensure support for every sequencer action type & abci query #1474

Closed
joroshiba opened this issue Sep 10, 2024 · 2 comments
Closed

cli: ensure support for every sequencer action type & abci query #1474

joroshiba opened this issue Sep 10, 2024 · 2 comments
Assignees
Labels
cli pertaining to the cli closed-stale stale

Comments

@joroshiba
Copy link
Member

joroshiba commented Sep 10, 2024

Currently astria-cli doesn't support all of our action types which is a hindrance to running manual and adding smoke tests. We want to support all action types, and abci query such that they are all easily tested through our domain types logic.

┆Issue Number: ENG-804

@joroshiba joroshiba added the cli pertaining to the cli label Sep 10, 2024
@quasystaty1 quasystaty1 self-assigned this Sep 18, 2024
github-merge-queue bot pushed a commit that referenced this issue Oct 16, 2024
## Summary
Adds Ics20Withdrawal command to the cli for
[Ics20Withdrawal](https://buf.build/astria/protocol-apis/docs/main:astria.protocol.transactions.v1alpha1#astria.protocol.transactions.v1alpha1.Ics20Withdrawal)
action

## Background
part of adding all sequencer actions as cli commands.
## Changes
- adds `astria-cli sequencer ics20-withdrawal` command

## Testing
- There will be a follow-up PR to add CLI test after the ongoing test
refactor is completed.
- Tested by performing a manual withdrawal to an IBC chain. Refunds the
sender address on failure, which was tested by sending an
Ics20Withdrawal with an invalid asset.

## Related Issues
part of #1474 
closes #1623

---------

Co-authored-by: Sam Bukowski <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Nov 6, 2024
## Summary
adds ibc sudo address change command
## Background
Cli currently does not support the `IbcSudoChange` action

## Changes
- added `IbcSudoChange` command to the cli as sudo command

## Testing
tested manually against dusk-11 network

## Related Issues
part of #1474
github-merge-queue bot pushed a commit that referenced this issue Nov 6, 2024
Summary
Adds bridge-sudo-change command for changing bridge privileges addresses

Background
Part of adding more actions to the cli

Changes
- adds `bridge-sudo-change` command setting bridge account privileges
addresses
- adds `bridge-account get` command querying bridge account information
Testing
Locally against a cluster

Related Issues
Part of #1474

closes #1547
@joroshiba
Copy link
Member Author

This issue is stale because it has been open 45 days with no activity. Remove stale label or this issue
be closed in 7 days.

@joroshiba
Copy link
Member Author

This issue was closed because it was stale

@joroshiba joroshiba closed this as not planned Won't fix, can't repro, duplicate, stale Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli pertaining to the cli closed-stale stale
Projects
None yet
Development

No branches or pull requests

3 participants