Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sequencer reports the wrong action as having failed #1465

Closed
SuperFluffy opened this issue Sep 6, 2024 · 0 comments · Fixed by #1505
Closed

Sequencer reports the wrong action as having failed #1465

SuperFluffy opened this issue Sep 6, 2024 · 0 comments · Fixed by #1505
Assignees
@itamarreif
Labels
sequencer pertaining to the astria-sequencer crate

Comments

@SuperFluffy
Copy link
Member

SuperFluffy commented Sep 6, 2024 •
edited
Loading

Sequencer reports that a bridge lock action failed even though it was checking a bridge unlock action.

The error message should be fixed. To not let this happen in the future: 1. Can the boiler plate also be replaced by a macro? And 2: can we make use of astria_core::Protobuf::full_name() to print the name of the failed action?

astria/crates/astria-sequencer/src/transaction/mod.rs

Lines 130 to 137 in f46d7f5

Action::BridgeLock(act) => act
.check_stateless()
.await
.context("stateless check failed for BridgeLockAction")?,
Action::BridgeUnlock(act) => act
.check_stateless()
.await
.context("stateless check failed for BridgeLockAction")?,

┆Issue Number: ENG-800
@SuperFluffy SuperFluffy added the sequencer pertaining to the astria-sequencer crate label Sep 6, 2024
@github-project-automation github-project-automation bot moved this to ⏳ Backlog in Astria Project Sep 6, 2024
@SuperFluffy SuperFluffy changed the title Duplicate error messages for two different actions is confusing Sequencer reports the wrong action as having failed Sep 6, 2024
@itamarreif itamarreif mentioned this issue Sep 13, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 17, 2024
@itamarreif
fix(sequencer): Fix incorrect error message from BridgeUnlock actions (…
1be156e 
…#1505)

## Summary
The error message for stateless checks on `BridgeUnlock` actions
incorrectly states `BridgeLock` as the failing error.

## Changes
- change the error message that wraps the stateless check for
`BridgeUnlock` actions

## Related Issues
Link any issues that are related, prefer full github links.

closes #1465
@github-project-automation github-project-automation bot moved this from ⏳ Backlog to ✅ Done in Astria Project Sep 17, 2024
quasystaty1 pushed a commit that referenced this issue Sep 17, 2024
@itamarreif @quasystaty1
fix(sequencer): Fix incorrect error message from BridgeUnlock actions (…
275139d 
…#1505)

The error message for stateless checks on `BridgeUnlock` actions
incorrectly states `BridgeLock` as the failing error.

- change the error message that wraps the stateless check for
`BridgeUnlock` actions

Link any issues that are related, prefer full github links.

closes #1465
quasystaty1 pushed a commit that referenced this issue Sep 17, 2024
@itamarreif @quasystaty1
fix(sequencer): Fix incorrect error message from BridgeUnlock actions (…
2307695 
…#1505)

The error message for stateless checks on `BridgeUnlock` actions
incorrectly states `BridgeLock` as the failing error.

- change the error message that wraps the stateless check for
`BridgeUnlock` actions

Link any issues that are related, prefer full github links.

closes #1465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itamarreif itamarreif

Labels
sequencer pertaining to the astria-sequencer crate
Projects
Astria Project
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sequencer): Fix incorrect error message from BridgeUnlock actions astriaorg/astria
2 participants
@SuperFluffy @itamarreif