Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

per-account asset reads are inefficient and inflexible #1452

Open
SuperFluffy opened this issue Sep 5, 2024 · 0 comments
Open

per-account asset reads are inefficient and inflexible #1452

SuperFluffy opened this issue Sep 5, 2024 · 0 comments

Comments

@SuperFluffy
Copy link
Member

SuperFluffy commented Sep 5, 2024

At the moment per-account asset reads 1 are inefficient, because they:

  1. read all keys by prefix
  2. issue one state-read per key.

They are also inflexible as surfaced in PR #1408 because they don't allow the call site to decide how the returned items should be processed.

The per-account asset reads should be implemented in terms of a stream using the cnidarium::Read::prefix_raw [2] to make the reads more efficient and flexible.

┆Issue Number: ENG-791

@astriaorg astriaorg deleted a comment Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant