Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sequencer: improve accounts/state_read_ext.rs get_account_balances() functions with async stream #1450

Closed
Lilyjjo opened this issue Sep 4, 2024 · 1 comment
Assignees
Labels
code-quality sequencer pertaining to the astria-sequencer crate

Comments

@Lilyjjo
Copy link
Contributor

Lilyjjo commented Sep 4, 2024

In writing PR #1408, it was not clear how to best return the balances of an account from the underlying database in a way that was useful for both the mempool and the query logic. The mempool needs a map and the query needs a sorted object with the goal of reduced allocations for both.

@SuperFluffy thinks writing an async stream would fix both

(will add code pointers after PR lands)

┆Issue Number: ENG-788

@Lilyjjo Lilyjjo added sequencer pertaining to the astria-sequencer crate code-quality labels Sep 4, 2024
@SuperFluffy
Copy link
Member

Closed by #1453 into #1408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality sequencer pertaining to the astria-sequencer crate
Projects
None yet
Development

No branches or pull requests

2 participants