Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up deposit constructor #1448

Closed
ethanoroshiba opened this issue Sep 4, 2024 · 1 comment
Closed

Clean up deposit constructor #1448

ethanoroshiba opened this issue Sep 4, 2024 · 1 comment
Assignees
@ethanoroshiba

Comments

@ethanoroshiba
Copy link
Contributor

ethanoroshiba commented Sep 4, 2024 •
edited by sync-by-unito bot
Loading

Currently, Deposit::new() as many arguments and is unwieldy. We should prefer try_from_raw where possible and look into a better way of constructing the object, potentially a builder.

#1410 (comment)

astria/crates/astria-core/src/sequencerblock/v1alpha1/block.rs

Lines 1317 to 1335 in 2911562

#[must_use]
pub fn new(
bridge_address: Address,
rollup_id: RollupId,
amount: u128,
asset: asset::Denom,
destination_chain_address: String,
id_of_source_transaction: TransactionId,
position_in_source_transaction: u64,
) -> Self {
Self {
bridge_address,
rollup_id,
amount,
asset,
destination_chain_address,
id_of_source_transaction,
position_in_source_transaction,
}

┆Issue Number: ENG-787
@github-project-automation github-project-automation bot moved this to ⏳ Backlog in Astria Project Sep 4, 2024
@ethanoroshiba ethanoroshiba self-assigned this Sep 16, 2024
@ethanoroshiba ethanoroshiba mentioned this issue Sep 16, 2024
Closed
@github-project-automation github-project-automation bot moved this from ⏳ Backlog to ✅ Done in Astria Project Sep 24, 2024
@ethanoroshiba
Copy link
Contributor Author

Completed in #1495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanoroshiba ethanoroshiba

Labels
None yet
Projects
Astria Project
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(core, sequencer): add deposit builder astriaorg/astria
1 participant
@ethanoroshiba