Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache introspected properties in ComparingProperties RecursiveComparisonIntrospectionStrategy #3158

Closed
joel-costigliola opened this issue Aug 26, 2023 · 1 comment
Closed

Cache introspected properties in ComparingProperties RecursiveComparisonIntrospectionStrategy #3158

joel-costigliola opened this issue Aug 26, 2023 · 1 comment
Labels
theme: recursive comparison An issue related to the recursive comparison
Milestone
3.25.0

Comments

@joel-costigliola
Copy link
Member

We already do that in DefaultRecursiveComparisonIntrospectionStrategy
ykardziyaka added a commit to ykardziyaka/assertj that referenced this issue Oct 28, 2023
@ykardziyaka
Cache node names in ComparingFields, ComparingProperties
6b95ed0 
Closes assertjgh-3157 and assertjgh-3158
@ykardziyaka ykardziyaka mentioned this issue Oct 28, 2023
Closed
joel-costigliola pushed a commit that referenced this issue Oct 29, 2023
@ykardziyaka @joel-costigliola
perf: cache node names in ComparingFields, ComparingProperties
98d2e27 
Closes gh-3157 and gh-3158
@joel-costigliola
Copy link
Member Author

Done in 98d2e27

@scordio scordio added the theme: recursive comparison An issue related to the recursive comparison label Oct 29, 2023
@scordio scordio added this to the 3.25.0 milestone Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
theme: recursive comparison An issue related to the recursive comparison
Projects
None yet
Milestone
3.25.0
Development

No branches or pull requests
2 participants
@joel-costigliola @scordio